resource-task: Use the shared IOUtils assertInPath method for resource lookups #1204
Conversation
benbroadaway
changed the title
| </dependency> | ||
| <dependency> | ||
| <groupId>org.apache.commons</groupId> | ||
| <artifactId>commons-compress</artifactId> |
There was a problem hiding this comment.
Why does it need commons-compress now? IIRC, it is only needed if you use zip* methods from concord-common.
There was a problem hiding this comment.
Not really sure? When I referenced the IOUtils class without it there were "ClassNotFound" errors for the Zip* classes which get imported in IOUtils. We (Ben and I) tried getting around that by using the concord-common dependency, but that didn't seem to confer transient dependencies? If you have ideas on how to fix this they would be welcome.
There was a problem hiding this comment.
commons-compress is not needed by the resource task, but it is a transitive dependency of concord-common. Since concord-common is provided scope, its transitive deps aren't loaded for the unit tests. It could probably just be test scope instead of provided here.
Using the IOUtils assertInPath to reduce duplicate code.