concord-server: retrieve user ldap groups for form access assertion #1233
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benbroadaway
changed the title
ibodrov
reviewed
Oct 23, 2025
|
|
||
| if (p.getRealm().equals("apikey")) { | ||
| // apikey realm doesn't look up groups by default, get them now | ||
| return ldapUserInfoProvider.getInfo(null, p.getUsername(), p.getDomain()).groups(); |
There was a problem hiding this comment.
There's also UserManager#getCurrentUserInfo
There was a problem hiding this comment.
Ahhh that's tidier and should work.
ibodrov
approved these changes
Oct 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, Form API (get, submit) doesn't work with API Key auth realm because the user principal's groups are not retrieved (we probably don't want to do that for every API call) when the form is restricted by
runAs.ldap.*. This change looks up those groups if/when they are necessary.