concord-db, concord-server: cache external app user mapping in database #1244
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-ldap-email-lookup
…ub-ldap-email-db-cache
benbroadaway
changed the title
…-ldap-email-lookup
…ub-ldap-email-db-cache
ibodrov
previously approved these changes
Dec 23, 2025
Collaborator
ibodrov
left a comment
ibodrov
left a comment
There was a problem hiding this comment.
Would it make sense to add a config option to enable/disable this behavior? It's an extra DB lookup for each GitHub event, right?
Otherwise, LGTM.
Collaborator
Author
Not for every event. This is a little bit further downstream. It's for an event that results in a triggered process (x the number of processes), and only when the trigger config has That being said, a config option to enable/disable is fair. I also just noticed a dumb typo. |
ibodrov
approved these changes
Dec 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds off #1242 and #1243.
Reduce calls to GitHub API by keeping the mapping of
github user -> concord userin Concord's database.This is a generic implementation for the mapping. Initially (the impetus for this PR), it's intended to help resolving github users to concord users. However, it can be used for any such mapping for other services that are integrated.