concord-server: use JSON for remember-me cookies#1333
Draft
ibodrov wants to merge 1 commit into
Draft
Conversation
Replace Java object serialization (ObjectOutputStream) with Jackson JSON serialization for remember-me cookie principals. This eliminates the remote code execution risk from deserialization gadget chains. Uses Jackson annotations and sealed records for clean polymorphic serialization: - PrincipalCollectionData -- top-level cookie container - PrincipalPayload (sealed interface) -- @JsonTypeInfo/@JsonSubTypes polymorphic dispatch - PrincipalPayload.Up -- UsernamePasswordToken - PrincipalPayload.Api -- concord ApiKey Legacy Java-serialized cookies fall back to ObjectInputFilter-protected deserialization, upgraded to JSON on next login.
ibodrov
force-pushed
the
ib/cookie-serialization
branch
from
3e207d6 to
82c5dac
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace Java object serialization (ObjectOutputStream) with JSON-based serialization for remember-me cookie principals.