Skip to content

concord-server: bind EventEnrichers explicitly #978

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 19, 2024
Merged

concord-server: bind EventEnrichers explicitly #978

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions server/impl/src/main/java/com/walmartlabs/concord/server/events/EventModule.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,5 +34,6 @@ public class EventModule implements Module {
public void configure(Binder binder) {
newSetBinder(binder, ProcessEventListener.class);
binder.bind(GithubTriggerProcessor.class).in(SINGLETON);
newSetBinder(binder, GithubTriggerProcessor.EventEnricher.class).addBinding().to(GithubTriggerProcessor.RepositoryInfoEnricher.class);
}
}
7 changes: 3 additions & 4 deletions ...pl/src/main/java/com/walmartlabs/concord/server/events/github/GithubTriggerProcessor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,12 +54,12 @@ public class GithubTriggerProcessor {
private static final Logger log = LoggerFactory.getLogger(GithubTriggerProcessor.class);

private final Dao dao;
private final List<EventEnricher> eventEnrichers;
private final Set<EventEnricher> eventEnrichers;
private final boolean isDisableReposOnDeletedRef;

@Inject
public GithubTriggerProcessor(Dao dao,
List<EventEnricher> eventEnrichers,
Set<EventEnricher> eventEnrichers,
GithubConfiguration githubCfg) {
this.dao = dao;
this.eventEnrichers = eventEnrichers;
Expand Down Expand Up @@ -203,8 +203,7 @@ public interface EventEnricher {
* Adds {@link Trigger#REPOSITORY_INFO} property to the event, but only if
* the trigger's conditions contained the clause with the same key.
*/
@Named
private static class RepositoryInfoEnricher implements EventEnricher {
public static class RepositoryInfoEnricher implements EventEnricher {

private final Dao dao;

Expand Down
Loading