base-context initialization #147
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
gersak
changed the title
|
Thanks for the assignment... Could you provide me with more info on what is expected? |
|
Hi, @hlship - I don't mean to be intrusive or overstep, but I'm having a little trouble understanding how can I contribute to make this change acceptable for merge. If it’s desirable, could you share a bit more on how I can help? Thanks in advance! |
|
I'm sorry, I have been quite busy with work and haven't had a chance to review this PR yet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This pull request addresses 2 changes.
First one is support for graphql-ws protocol specification: https://github.com/enisdenjo/graphql-ws/blob/master/PROTOCOL.md that is supported in newer versions of GraphiQL
Second one is base-context initialisation for connection-loop. Currently in subscriptions namespace there is no other way to extend base-context and include some ws request params data into base-context that connection-loop will use to process incoming GraphQL subscription request.
Why? Authorization i.e. If access_token is sent during ws establishment and user info (roles, groups) are important for subscription execution, base-context feels like logical place to hold that information. Since it is available to all subscription resolvers. Right?
If I misunderstood current codebase i apologise and would be really grateful if u could show me workarounds.
Thanks,
Robert