Support interface implementing another interface - #473
Merged
Conversation
Per GraphQL spec (October 2021), interfaces may now implement other interfaces. - Update ANTLR grammar: interfaceDef accepts optional implementationDef - Regenerate GraphqlSchemaParser.java - Update SDL parser xform for interfaceDef to capture implements - Update ::interface spec to allow optional ::implements - compile-type :interface validates implemented types exist and are interfaces - prepare-and-validate-interfaces: expands object :implements transitively, validates sub-interface declares all parent fields, expands :members to include objects that implement via sub-interfaces - add check-compatible [:interface :interface] for covariant field types - introspection resolve-interfaces returns implemented interfaces for interface types (nil when none, consistent with prior object behavior) 🤖 Generated with [eca](https://eca.dev) Co-Authored-By: eca-agent <git@eca.dev>
- interface implementing itself is caught in compile-type :interface - indirect cycles (A->B->C->A) caught in prepare-and-validate-interfaces by checking if an interface appears in its own transitive implements set 🤖 Generated with [eca](https://eca.dev) Co-Authored-By: eca-agent <git@eca.dev>
hlship
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
implementson interface definitions:membersand type compatibility)🤖 Generated with eca