fix: detect unconsumed tokens after parse to catch unbalanced braces (#445) - #475
Merged
Merged
Conversation
…445) ANTLR's default error recovery silently absorbed certain malformed queries (e.g. missing opening braces) without ever calling the syntaxError listener, producing a structurally different but syntactically valid parse tree and leaving trailing tokens unconsumed. Fix by comparing the document tree's stop-token index against the last non-EOF token after parsing; throw ParseError if any tokens were skipped. Also fix two test queries that had a genuine extra `}` that was previously silently ignored: entities-query in federation_tests and later-fragments-do-not-override-earlier in fragments_tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ParseErrorif any remain — catches cases where ANTLR's default error recovery silently accepted malformed queries (e.g. missing opening braces)}that was previously silently ignored:entities-queryinfederation_testsandlater-fragments-do-not-override-earlierinfragments_testsunbalanced-bracesregression test covering both cases from issue Unbalanced braces in queries not causing parse-query to fail #445Closes #445
🤖 Generated with eca
Co-Authored-By: eca-agent git@eca.dev