antimage

Author: walpurr

app/src/main/java/hexlet/code/games/Calc.java

@@ -6,15 +6,15 @@ public class Calc {
     public static void play(Scanner scanner) {
         Engine.greet(scanner);
 
-        var randomNumberBound = 50;
-        var randomOperatorBound = 3;
+        final var RANDOM_NUMBER_BOUND = 50;
+        final var RANDOM_OPERATOR_BOUND = 3;
 
         while (Engine.isContinuing()) {
-            var number1 = Engine.getRandomNumber(randomNumberBound);
-            var number2 = Engine.getRandomNumber(randomNumberBound);
+            var number1 = Engine.getRandomNumber(RANDOM_NUMBER_BOUND);
+            var number2 = Engine.getRandomNumber(RANDOM_NUMBER_BOUND);
             char operator;
 
-            int correctAnswer = switch (Engine.getRandomNumber(randomOperatorBound)) {
+            int correctAnswer = switch (Engine.getRandomNumber(RANDOM_OPERATOR_BOUND)) {
                 case 0 -> {
                     operator = '+';
                     yield number1 + number2;

app/src/main/java/hexlet/code/games/Engine.java

@@ -8,7 +8,7 @@ public class Engine {
     private static boolean defeated = false;
     private static int currentRound = 1;
     private static final int FINAL_ROUND = 3;
-    private static Random randomizer = new Random();
+    private static final Random RANDOMIZER = new Random();
 
     public static void greet(Scanner scanner) {
         System.out.println("Welcome to the Brain Games!");
@@ -22,7 +22,7 @@ public static boolean isContinuing() {
     }
 
     public static int getRandomNumber(int bound) {
-        return randomizer.nextInt(bound);
+        return RANDOMIZER.nextInt(bound);
     }
 
     public static void compareAnswers(String userAnswer, String correctAnswer) {

app/src/main/java/hexlet/code/games/Even.java

@@ -7,10 +7,10 @@ public static void play(Scanner scanner) {
         Engine.greet(scanner);
         System.out.println("Answer 'yes' if the number is even, otherwise answer 'no'.");
 
-        var randomNumberBound = 100;
+        final var RANDOM_NUMBER_BOUND = 100;
 
         while (Engine.isContinuing()) {
-            var randomNumber = Engine.getRandomNumber(randomNumberBound) + 1; // added 1 to avoid 0
+            var randomNumber = Engine.getRandomNumber(RANDOM_NUMBER_BOUND) + 1; // added 1 to avoid 0
             var correctAnswer = randomNumber % 2 == 0 ? "yes" : "no";
 
             System.out.println("Question: " + randomNumber);

app/src/main/java/hexlet/code/games/GCD.java

@@ -10,11 +10,11 @@ public static int getGCD(int a, int b) {
     public static void play(Scanner scanner) {
         Engine.greet(scanner);
 
-        var randomNumberBound = 100;
+        final var RANDOM_NUMBER_BOUND = 100;
 
         while (Engine.isContinuing()) {
-            var number1 = Engine.getRandomNumber(randomNumberBound) + 1; // added 1 to avoid 0
-            var number2 = Engine.getRandomNumber(randomNumberBound) + 1;
+            var number1 = Engine.getRandomNumber(RANDOM_NUMBER_BOUND) + 1; // added 1 to avoid 0
+            var number2 = Engine.getRandomNumber(RANDOM_NUMBER_BOUND) + 1;
             int correctAnswer = getGCD(number1, number2);
 
             System.out.println("Find the greatest common divisor of given numbers.");

app/src/main/java/hexlet/code/games/Prime.java

@@ -21,10 +21,10 @@ public static void play(Scanner scanner) {
         Engine.greet(scanner);
         System.out.println("Answer 'yes' if given number is prime. Otherwise answer 'no'.");
 
-        var randomNumberBound = 82; // multiplication table range
+        final var RANDOM_NUMBER_BOUND = 82; // multiplication table range
 
         while (Engine.isContinuing()) {
-            var randomNumber = Engine.getRandomNumber(randomNumberBound);
+            var randomNumber = Engine.getRandomNumber(RANDOM_NUMBER_BOUND);
             var correctAnswer = isPrime(randomNumber) ? "yes" : "no";
 
             System.out.println("Question: " + randomNumber);

app/src/main/java/hexlet/code/games/Progression.java

@@ -5,15 +5,15 @@
 
 public class Progression {
     public static int[] getRandomProgression() {
-        var progressionSize = 10;
-        var randomElementOfProgressionBound = 20;
-        var randomStepBound = 10;
+        final var PROGRESSION_SIZE = 10;
+        final var RANDOM_ELEMENT_OF_PROGRESSION_BOUND = 20;
+        final var RANDOM_STEP_BOUND = 10;
 
-        int[] progression = new int[progressionSize];
-        progression[0] = Engine.getRandomNumber(randomElementOfProgressionBound);
-        var step = Engine.getRandomNumber(randomStepBound) + 1;
+        int[] progression = new int[PROGRESSION_SIZE];
+        progression[0] = Engine.getRandomNumber(RANDOM_ELEMENT_OF_PROGRESSION_BOUND);
+        var step = Engine.getRandomNumber(RANDOM_STEP_BOUND) + 1;
 
-        for (var i = 1; i < progressionSize; i++) {
+        for (var i = 1; i < PROGRESSION_SIZE; i++) {
             progression[i] = progression[i - 1] + step;
         }
 
@@ -23,11 +23,11 @@ public static int[] getRandomProgression() {
     public static void play(Scanner scanner) {
         Engine.greet(scanner);
 
-        var randomHiddenElementBound = 10;
+        final var RANDOM_HIDDEN_ELEMENT_BOUND = 10;
 
         while (Engine.isContinuing()) {
             int[] progression = getRandomProgression();
-            var hiddenElement = progression[Engine.getRandomNumber(randomHiddenElementBound)];
+            var hiddenElement = progression[Engine.getRandomNumber(RANDOM_HIDDEN_ELEMENT_BOUND)];
             var correctAnswer = Integer.toString(hiddenElement);
 
             StringJoiner progressionForQuestion = new StringJoiner(" ");