fix client_id for iso_18013_7_mdoc profile.#1510
Open
jann0k wants to merge 1 commit intowalt-id:mainfrom
Open
Conversation
…"x509_san_dns"`, then `client_id` MUST be a DNS name and match a dNSName Subject Alternative Name in x5c https://openid.net/specs/openid-4-verifiable-presentations-1_0-20.html#name-verifier-metadata-managemen
|
No actionable comments were generated in the recent review. 🎉 📝 WalkthroughWalkthroughModified clientId selection logic in OpenIDCredentialVerifier for the ISO_18013_7_MDOC profile, switching from using redirectUri to clientIdMap lookup with defaultClientId fallback. Changes
🚥 Pre-merge checks | ✅ 2 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Tip Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When
"client_id_scheme":"x509_san_dns", thenclient_idMUST be a DNS name and match a dNSName Subject Alternative Name inx5chttps://openid.net/specs/openid-4-verifiable-presentations-1_0-20.html#name-verifier-metadata-managemen
If
x509SanDnsClientIdis configured withrequestSigningKeyFileandrequestSigningCertFilein verifier-service.confand Autorization Request is done as with ISO_18013_7_MDOC profile as in https://docs.walt.id/community-stack/verifier/credential-verification/mdl-oid4vc, then payload of Request Object (jwt) from
request_uriwill containclient_idwith value ofx509SanDnsClientIdfromverifier-service.confDocker image
To build docker image (from waltid-identity root):
Test
verifier-service.conf:Request Object (jwt):
jwt decoded with https://jwt.io:
{ "response_uri": "http://localhost:7003/openid4vc/verify/9QNPaYAVBQJj", "aud": "", "client_id_scheme": "x509_san_dns", "iss": "verifier.potential.walt-test.cloud", "response_type": "vp_token", "presentation_definition": { "id": "LKMQbX2cngfS", "input_descriptors": [ { "id": "org.iso.18013.5.1.mDL", "format": { "mso_mdoc": { "alg": [ "ES256" ] } }, "constraints": { "fields": [ { "path": [ "$[org.iso.18013.5.1][birth_date]" ], "intent_to_retain": false }, { "path": [ "$[org.iso.18013.5.1][issue_date]" ], "intent_to_retain": false }, { "path": [ "$[org.iso.18013.5.1][expiry_date]" ], "intent_to_retain": false } ], "limit_disclosure": "required" } } ] }, "state": "9QNPaYAVBQJj", "exp": 1770995692, "nonce": "1c6aa8df-3923-4e05-a22d-e3592fb6639f", "client_id": "verifier.potential.walt-test.cloud", "client_metadata": { "jwks": { "keys": [ { "kty": "EC", "crv": "P-256", "kid": "uUsEI8KxedEubahM-SKHFNiHnHA7E_InwazGaBClpg4", "x": "XopZYqK5PmyNV1XydM7q5cwmFh2TOdgC8Tqww_cR02Y", "y": "w6VEzT2UOvN4iUFtogVbtwqjy3Xi0z6oA06hWdZFqus", "use": "enc", "alg": "ECDH-ES" } ] }, "authorization_encrypted_response_alg": "ECDH-ES", "authorization_encrypted_response_enc": "A256GCM" }, "response_mode": "direct_post.jwt" }Type of Change
Checklist
Breaking
Summary by CodeRabbit