Skip to content

Feat/portal2#1883

Open
JakeFernandes98 wants to merge 14 commits into
mainfrom
feat/portal2
Open

Feat/portal2#1883
JakeFernandes98 wants to merge 14 commits into
mainfrom
feat/portal2

Conversation

@JakeFernandes98

Copy link
Copy Markdown
Contributor

Makes some improvements to the Portal 2:

  • Adds a simplified mode
  • Adds customisable options for signing and certificates

@coderabbitai

coderabbitai Bot commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: d7a13eb4-3ace-4250-bf16-22ff1000a019

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@JakeFernandes98 JakeFernandes98 marked this pull request as draft July 9, 2026 10:39
@JakeFernandes98 JakeFernandes98 marked this pull request as ready for review July 13, 2026 09:55
@dinkar-jain

Copy link
Copy Markdown
Contributor

QR Overflow - Also happening during issuance with tx-code
image

@dinkar-jain

dinkar-jain commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

Simple mode doesn't preserve state. If you change the selection from its default, switch to "Verify from "Issue," and switch back, the selection resets. Advanced mode preserves it. Not a priority, just something to note.

Similarly for "Issuance flow" states in "Issue" and "Claims to request" in "Verify" too

@dinkar-jain

Copy link
Copy Markdown
Contributor

Button State: The button should probably also change color, and the cursor should switch from pointer to not-allowed to clearly communicate that the action is currently unavailable.

image

@JakeFernandes98

Copy link
Copy Markdown
Contributor Author

Resolved by:

  • Removing raw openid link from the QR code generation, opting instead for a "Copy openid link" button for more predictable UI sizing
  • Added state preservation across navigation
  • Added invalid button state

@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants