first draft of android elegible tasks#1903
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Run Android CI only for Android-relevant changes while preserving explicit release/manual Android builds. Co-authored-by: Cursor <cursoragent@cursor.com>
JakeFernandes98
force-pushed
the
ci/android-selective-run
branch
from
1ccff56 to
0e64e88
Compare
szijpeter
left a comment
szijpeter
left a comment
There was a problem hiding this comment.
Looks pretty good to me already 👍🏼
Couple of non-blocking improvement suggestions to make this policy easier to operate and maintain:
-
Add a combined full-mobile opt-in label.
Suggested semantics:
ci:android: run Android CI onlyci:macos: run iOS/macOS CI onlyci:mobile: run both Android and iOS/macOS CI
That would keep the precise platform-specific escape hatches while providing one obvious label for a full mobile validation sweep.
-
Extract the shared eligibility logic.
The Android eligibility workflow now mirrors most of the macOS/iOS workflow shape from #1887: event handling, same-repo/fork policy, draft behavior, label opt-ins, PR changed-file lookup, and
should-run/reasonoutputs. It may be worth moving that common orchestration into one reusable mobile eligibility workflow, with Android and macOS/iOS passing only their platform-specific labels and path patterns.That should reduce drift between the Android and macOS/iOS policies as they evolve.
|
2 participants
Extends the selective CI runs to be more picky about running android jobs