Merged
Conversation
- Add missing version for maven-source-plugin (3.4.0) - Extract hardcoded os-maven-plugin and maven-failsafe-plugin versions into properties - Remove duplicate jackson-dataformat-yaml.version property - Move jacoco-maven-plugin.version to root POM to eliminate duplication - Standardize property naming: protoc-version -> protoc.version, protoc-gen-grpc-java -> protoc-gen-grpc-java.version, palantir-format-version.version -> palantir-java-format.version - Add maven-failsafe-plugin and maven-source-plugin to pluginManagement - Reorganize properties: plugin versions grouped separately from dependency versions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
maven-source-plugin(3.4.0) in root POM and capabilities-exchangeos-maven-plugin(1.7.1) andmaven-failsafe-plugin(3.5.5) versions into properties in capabilities-parentjackson-dataformat-yaml.versionproperty in capabilities-parentjacoco-maven-plugin.versionfrom coverage profile to root POM main properties to eliminate duplication with capabilities-parentprotoc-version->protoc.version,protoc-gen-grpc-java->protoc-gen-grpc-java.version,palantir-format-version.version->palantir-java-format.versionmaven-failsafe-pluginandmaven-source-pluginto pluginManagement in capabilities-parentTest plan
mvn verifypasses (all 21 code modules succeed; archetype IT failure is pre-existing on main)