fix(cmake): gate C interface behind WANNIER90_WITH_C - #653
Merged
JeromeCCP9 merged 2 commits intoJul 20, 2026
Conversation
Contributor
|
All contributors have accepted the CLA ✅ You might need to click the "Update/Rebase branch" button to update the pull request and rerun the GitHub actions to pass the CLA check. |
Contributor
Author
|
I have read the CLA Document and I hereby accept the CLA |
JeromeCCP9
approved these changes
Jul 20, 2026
JeromeCCP9
left a comment
JeromeCCP9
left a comment
Collaborator
There was a problem hiding this comment.
Thank you so much for this work!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
README.installmentions using-DWANNIER90_WITH_C=ONto build the C interface, but the option does not appear to be defined and used to gate inclusion of the C interface sources and install of the C interface.