Fix compatibility with MariaDB 12 (and future versions) by mattijv · Pull Request #939 · wardenenv/warden

mattijv · 2026-06-26T08:16:03Z

Issue

Trying to use MariaDB 12 in a Magento project caused the db (and tmp-mysql) service to fail with the following error:

2026-06-16 06:59:44+00:00 [Note] [Entrypoint]: Entrypoint script for MariaDB Server 1:12.2.2+maria~ubu2404 started.
2026-06-16 06:59:44+00:00 [ERROR] [Entrypoint]: mariadbd failed while attempting to check config
        command was: mysqld --max_allowed_packet=1024M --explicit_defaults_for_timestamp=on --verbose --help
        /usr/local/bin/docker-entrypoint.sh: line 105: mysqld: command not found

This is due to MariaDB removing the mysql compatibility symlinks from their Docker images by default.

In addition the warden db commands do not work, for the same reason.

This was previously fixed in wardenenv/images#50 by explicitly installing the MySQL compatibility packages if the MariaDB version was 11. However, that fix does not work when using 12 (12.3 is the suggested version for newer Magento releases).

We could fix the issue by always installing the compatibility packages (instead of just for MariaDB 11). This PR offers a different approach.

Steps to reproduce

A Magento 2 environment with this configuration for the DB.

MYSQL_DISTRIBUTION=mariadb
MYSQL_DISTRIBUTION_VERSION=12.2

Proposed Fix

Services

For the DB services we can let the container entrypoint script to determine the correct command, instead of providing an explicit one.

Inspecting even older MySQL/MariaDB image entrypoint scripts

docker run --rm --entrypoint cat mysql:5.6 /usr/local/bin/docker-entrypoint.sh

show that they all (that I spot checked, at least) have this kind of snippet in the beginning of the main part of the script

_main() {
	# if command starts with an option, prepend mysqld
	if [ "${1:0:1}" = '-' ]; then
		set -- mysqld "$@"
	fi

So we do not actually need to provide the explicit command at all, but the container can decide what command to use.

Commands

The db command has previously used the MYSQL_DISTRIBUTION environment variable for deciding which DB upgrade command to use.

This PR changes the command to do the same also for the client and dump commands.

Using MYSQL_DISTRIBUTION

I don't know if the warden db upgrade command has ever worked, as the MYSQL_ variables are read from the container's environment variables, and the MYSQL_DISTRIBUTION was never added there. In testing the command just failed for me.

This PR fixes that issue by including the MYSQL_DISTRIBUTION in the DB container environment, though that feels a tad hacky to be honest.

Copilot

Pull request overview

This PR updates Warden environment DB service definitions to improve compatibility with newer MariaDB images (e.g., MariaDB 12) by no longer hardcoding the server binary (mysqld) in compose command: arrays, relying instead on the image entrypoint behavior when the first argument is an option.

Changes:

Removed explicit mysqld from several environment DB service command: lists so the container entrypoint can select the correct server binary.
Updated Magento split DB and test DB service definitions to follow the same pattern.
Added an UNRELEASED changelog entry referencing the fix for #864.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
environments/magento2/magento2.tests.base.yml	Removes explicit `mysqld` from tmp DB command so entrypoint can choose the correct binary.
environments/magento2/magento2.splitdb.sales.base.yml	Removes explicit `mysqld` from sales split DB service command.
environments/magento2/db.base.yml	Removes explicit `mysqld` from main Magento 2 DB service command.
environments/magento1/db.base.yml	Removes explicit `mysqld` from Magento 1 DB service command.
environments/drupal/db.base.yml	Removes explicit `mysqld` from Drupal DB service command.
environments/cakephp/db.base.yml	Removes explicit `mysqld` from CakePHP DB service command.
CHANGELOG.md	Notes the fix in the UNRELEASED “Bug Fixes” section.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

mattijv · 2026-06-26T08:34:43Z

Noticed the the db command also uses mysql for the commands, which won't work with newer MariaDB images. I'll change that as well.

Copilot

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.

Copilot

Pull request overview

Copilot reviewed 14 out of 14 changed files in this pull request and generated 4 comments.

The entrypoint script in the MySQL/MariaDB images automatically prepend the correct binary name to the command if the first argument starts with the "-" character. Since MariaDB removed the MySQL compatibility symlinks from their Docker images, the previous "mysql" command started failing. This commit removes the explicit command name from the DB service definitions, since the entrypoints (in both MySQL and MariaDB images) are smart enough to prepend the correct command if we just supply the arguments.

MariaDB stopped including the `mysql` symlinks in the official Docker images, so now the commands using `mysql` or `mysqldump` are failing with newer MariaDB versions. This commit adds logic to determine the appropriate commands to use based on the MYSQL_DISTRIBUTION (as that was already used previously for the `warden db upgrade` subcommand). However, it seems like the upgrade subcommand has never worked! The MYSQL_ variables are exctracted from the DB containter environment variables, but the MYSQL_DISTRIBUTION was never added as an environment variable in the DB containers. Running the upgrade command results in the following: ERROR: The upgrade command only supports MySQL and MariaDB installations. This commit changes the DB services to include the MYSQL_DISTRIBUTION in the environment variables, so it can be used in the warden commands as intended(?).

Copilot

Pull request overview

Copilot reviewed 14 out of 14 changed files in this pull request and generated 1 comment.

mattijv · 2026-06-26T10:41:23Z

+case "${MYSQL_DISTRIBUTION}" in
+    mariadb)
+        clientCmd="mariadb"
+        dumpCmd="mariadb-dump"
+        ;;
+    *)
+        clientCmd="mysql"
+        dumpCmd="mysqldump"
+        ;;
+esac


This is backwards compatible to how it worked previously. Not in the scope to change that, unless requested by the maintainers.

Copilot AI review requested due to automatic review settings June 26, 2026 08:16

github-project-automation Bot added this to Warden Jun 26, 2026

Copilot started reviewing on behalf of mattijv June 26, 2026 08:16 View session

Copilot AI reviewed Jun 26, 2026

View reviewed changes

Comment thread environments/magento2/db.base.yml

Comment thread CHANGELOG.md

mattijv force-pushed the fix-db-service-command branch 2 times, most recently from 5bb450e to 23a39d4 Compare June 26, 2026 08:32

mattijv requested a review from Copilot June 26, 2026 08:33

Copilot started reviewing on behalf of mattijv June 26, 2026 08:33 View session

Copilot AI reviewed Jun 26, 2026

View reviewed changes

Comment thread environments/shopware/db.base.yml

mattijv force-pushed the fix-db-service-command branch 2 times, most recently from 0e1ea88 to a03dbfe Compare June 26, 2026 10:26

mattijv requested a review from Copilot June 26, 2026 10:26

Copilot started reviewing on behalf of mattijv June 26, 2026 10:26 View session

Copilot AI reviewed Jun 26, 2026

View reviewed changes

Comment thread commands/db.cmd

Comment thread commands/db.cmd

Comment thread environments/shopware/db.base.yml Outdated

Comment thread commands/db.cmd Outdated

mattijv added 2 commits June 26, 2026 13:33

mattijv force-pushed the fix-db-service-command branch from a03dbfe to 8b7b8b5 Compare June 26, 2026 10:33

mattijv requested a review from Copilot June 26, 2026 10:34

Copilot started reviewing on behalf of mattijv June 26, 2026 10:34 View session

Copilot AI reviewed Jun 26, 2026

View reviewed changes

mattijv changed the title ~~Remove explicit mysql from DB service commands (fixes compatibility with MariaDB 12)~~ Fix compatibility with MariaDB 12 (and future versions) Jun 26, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Fix compatibility with MariaDB 12 (and future versions)#939

Fix compatibility with MariaDB 12 (and future versions)#939
mattijv wants to merge 2 commits into
wardenenv:mainfrom
mattijv:fix-db-service-command

mattijv commented Jun 26, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

mattijv commented Jun 26, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

mattijv Jun 26, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Uh oh!

Conversation

mattijv commented Jun 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Issue

Steps to reproduce

Proposed Fix

Services

Commands

Using MYSQL_DISTRIBUTION

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

mattijv commented Jun 26, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

mattijv Jun 26, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

mattijv commented Jun 26, 2026 •

edited

Loading