Skip to content

fix: honor stderrthreshold when logtostderr is enabled #192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pierluigilenoci wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: honor stderrthreshold when logtostderr is enabled #192

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions cmd/plugin/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,17 @@ func main() {
if err := flag.Set("logtostderr", "true"); err != nil {
panic(err)
}
// Since kubernetes/klog#432 the legacy behaviour of copying WARNING+
// to stderr when logtostderr=true is deprecated. Explicitly request
// all severities on stderr so that log output keeps working as before.
if err := flag.Set("stderrthreshold", "INFO"); err != nil {
panic(err)
}
// Disable the legacy stderr threshold behaviour so that our explicit
// stderrthreshold=INFO takes full effect regardless of klog version.
if err := flag.Set("legacy_stderr_threshold_behavior", "false"); err != nil {
panic(err)
}

flag.Parse()
defer klog.Flush()
Expand Down