review-pr-local: make report_error! form audit mandatory (APP-5522) - #15296
Merged
Conversation
Add a dedicated Pre-Verdict Audit section that requires enumerating one with file:line, and checking each against logging-and-error-reporting/SKILL.md for the forbidden forms (real error demoted into extra:, typed error stringified into the grouping message, variable data interpolated into the grouping message, double-reporting away from the sink). Replaces the single narrative bullet (buried in a long list) that already named this anti-pattern but was easy to under-apply on a mega-diff, per APP-5522.
Contributor
Author
|
This PR was generated with Warp. Comment   |
acarl005
approved these changes
Aug 19, 2026
acarl005
marked this pull request as ready for review
August 19, 2026 00:39
acarl005
approved these changes
Aug 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Review-prompting fix for APP-5522 (the code-side
report_error!form fixes are a separate PR)..agents/skills/review-pr-local/SKILL.mdalready named the "typed error demoted intoextra:" anti-pattern (added in #13483 itself), but only as one prose bullet inside a long list — so it was easy to under-apply on that PR's 345-file, ~974-report_error!-line diff, which is exactly what happened: the bot's review found 2 unrelated compile bugs and zero form findings, including on the very lines (crates/warpui_core/src/runtime/mod.rs:813and:709) that used the forbidden form.Companion PR (adds the matching mandatory-audit category to the core skill): warpdotdev/common-skills#76
This is a review-prompting-only change (skill markdown). No Rust code is touched; a separate PR fixes the flagged
report_error!call sites themselves.ready-to-specorready-to-implement.Linked Issue
APP-5522
What a reviewer would now do differently on PR #13483's diff
Before: the reviewer read "review it against
.agents/skills/logging-and-error-reporting/SKILL.md" as one bullet among a dozen others, with no requirement to look at every call site individually — easy to satisfy with a spot-check on a mega-diff. After: a dedicated## Pre-Verdict Audit: error-reporting formsection (mirroring the core skill's Comments/Tests audit, added in the companion PR) makes it mandatory, before drafting the body or verdict, to list everyreport_error!/report_if_error!call the diff adds or changes, one by one with file:line, and check each against the four named forbidden forms. That per-line enumeration — not a narrative pass — is what would have surfaced theextra: { "error" => %error }demotion atruntime/mod.rs:813/:709before merge.Testing
Docs-only change (
.agents/skills/review-pr-local/SKILL.md). No Rust code changed, socargo clippydoesn't apply;./script/formatwas run and made no additional changes../script/run— N/A, no runtime behavior; this only changes a skill markdown file read by the review agent.Screenshots / Videos
N/A — not a UI change.
Agent Mode