Skip to content

Add image upload to user profile page - #466

Draft
MrQubo wants to merge 1 commit into
warsztatywww:masterfrom
MrQubo:profile-page-images
Draft

Add image upload to user profile page#466
MrQubo wants to merge 1 commit into
warsztatywww:masterfrom
MrQubo:profile-page-images

Conversation

@MrQubo

@MrQubo MrQubo commented May 7, 2021

Copy link
Copy Markdown
Member

Not #319 but it's at least something.


This change is Reviewable

Comment thread wwwapp/views.py
@MrQubo

MrQubo commented May 7, 2021

Copy link
Copy Markdown
Member Author

Similar CI error as in #465. 0.o

@krzys-h krzys-h left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We didn't allow uploads in the profile description by design (you don't really need it, and it would be the only non-admin upload form at the time - with all the security implications of that. Not really true anymore though ¯\(ツ)/¯)

I'm still not convinced we need it. @cytadela8 wanted a field in the profile, not image uploads on the profile page. We already have a problem with the workshop pages having images pasted in random places instead of one designated spot, which usually doesn't work on mobile (and that is where most of users browsing these pages are). We should work on fixing that, instead of making it worse by introducing the same problem elsewhere.

@cytadela8

Copy link
Copy Markdown
Member

It's a good point about this not working great for mobile!

@krzys-h
krzys-h marked this pull request as draft April 26, 2022 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants