Skip to content

Improve homepage - #692

Open
mhorod wants to merge 9 commits into
masterfrom
mh/main-page-remind-me-button
Open

Improve homepage#692
mhorod wants to merge 9 commits into
masterfrom
mh/main-page-remind-me-button

Conversation

@mhorod

@mhorod mhorod commented Mar 3, 2026

Copy link
Copy Markdown
Contributor

There was a request to add "Remind me about registration" button to the main page, but the current setup is that main page is a special kind of article, which makes adding such button problematic.

I feel like instead of hacking some solution we can just make the main page a separate (dynamic) view in django.
A slight incovenience is that any changes to the content have to be done via a PR - but I feel it's done rarely enough we can excuse it.

I also used this occasion to move the items on the page slightly, to improve layout and readability.


This change is Reviewable

@mhorod

mhorod commented Mar 3, 2026

Copy link
Copy Markdown
Contributor Author

For now the MR is still a draft:

  • the facebook iframe doesn't resize
  • I want to test error handling of the added button
  • and maybe add some tests for the index view as well, and fix failing tests

@krzys-h

krzys-h commented Mar 3, 2026

Copy link
Copy Markdown
Member

Note: the facebook iframe resize has been semi-broken for a while, so this may be unrelated to your changes

@mhorod
mhorod force-pushed the mh/main-page-remind-me-button branch from f16d184 to d9a80e2 Compare March 5, 2026 08:31
@mhorod

mhorod commented Mar 5, 2026

Copy link
Copy Markdown
Contributor Author
image image image

@mhorod
mhorod marked this pull request as ready for review March 5, 2026 10:48
@cytadela8

Copy link
Copy Markdown
Member

@codex review this

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 0b9112365a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread templates/index.html Outdated
Comment thread templates/index.html Outdated
Comment thread frontend/js/warsztatywww.js
Comment thread templates/index.html

<div class="card mt-2">
<div class="card-body">
{{ camp_dates }}

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I converted this section into an article - we can manually edit it and fill it in with the following HTML:

<h4 class="card-title"><i class="fas fa-calendar text-primary"></i> Terminy WWW22 (2026)</h4>
                <table class="table table-sm lg-table-md table-align-middle m-0">
                    <tbody>
                        <tr>
                            <td>do 31 marca</td>
                            <td><a href="{% url 'workshops_add' current_year.pk %}"><strong>Zgłoszenia warszatów</strong></a>
                            </td>
                        </tr>
                        <tr>
                            <td>do 19 kwietnia</td>
                            <td>Pojawiają się strony warsztatów i zadania kwalifikacyjne</td>
                        </tr>
                        <tr>
                            <td>do 31 maja</td>
                            <td>Czas na rozwiązywanie <a href="{% url 'program' current_year.pk %}"><strong>zadań
                                        kwalifikacyjnych</strong></a> przez uczestników</td>
                        </tr>
                        <tr>
                            <td>16 czerwca</td>
                            <td>Informacja o kwalifikacji</td>
                        </tr>
                        <tr>
                            <td>3 &ndash; 16 sierpnia</td>
                            <td><strong>Warsztaty</strong>, odbywające się w <strong>Zabrzu</strong></td>
                        </tr>
                    </tbody>
                </table>

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

*This needs to be done before the deployment, so that the dates are present on the main page.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image

@cytadela8

Copy link
Copy Markdown
Member

@codex rereview please. Also explain the actions needed to be taken after the deployment and any limitations this new design imposes.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 1221d846ef

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread templates/index.html Outdated
Comment thread wwwapp/views.py
Comment thread wwwapp/views.py Outdated
@mhorod
mhorod force-pushed the mh/main-page-remind-me-button branch from 1221d84 to 2b71269 Compare April 23, 2026 07:16
@cytadela8

Copy link
Copy Markdown
Member

@codex rereview.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 2b71269fa2

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread wwwapp/views.py Outdated
Comment thread wwwapp/views.py
cytadela8
cytadela8 previously approved these changes May 3, 2026

@cytadela8 cytadela8 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think its good. Maybe you can update the SPECIAL_ARTICLES const

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants