Add AbstractRange and StaticRange interfaces#4221
Add AbstractRange and StaticRange interfaces#4221guybedford merged 7 commits intowasm-bindgen:mainfrom
AbstractRange and StaticRange interfaces#4221Conversation
behrenle
force-pushed
the
add-static-range-interface
branch
from
c73ef02 to
2298ee6
Compare
behrenle
force-pushed
the
add-static-range-interface
branch
2 times, most recently
from
d2f1cb9 to
576087a
Compare
|
@daxpedda I have incorporated your requested changes and would appreciate another review. Unfortunately, I can't remove the 'waiting for author' label myself. |
|
Ah, this PR is just what i need, thank you @behrenle |
|
Oh, unfortunately i can't use this as a git dependency due to the "links" tag - It's not impossible to get it to work temporarily, but i would definetely appreciate if this were merged sometime in the coming months |
|
@kartonrad I’m facing the same issue, but I’m still waiting for a follow-up review from @daxpedda. Hopefully, we can get this merged soon! |
guybedford
force-pushed
the
add-static-range-interface
branch
from
576087a to
1b14293
Compare
guybedford
force-pushed
the
add-static-range-interface
branch
from
1b14293 to
6564f50
Compare
guybedford
left a comment
guybedford
left a comment
There was a problem hiding this comment.
I've rebased this to the latest main branch, would be great to land along with the CSS Highlight API WebIDL updates for the next release.
The spec defines the constructor as variadic AbstractRange..., not sequence<AbstractRange>. This was incorrectly changed in a previous update. Now that AbstractRange is defined, the generator correctly produces both the variadic binding and typed overloads.
daxpedda
left a comment
daxpedda
left a comment
There was a problem hiding this comment.
I apologize for never getting back to this!
I'm glad @guybedford is picking up the slack here.
|
Thank you <3 @guybedford @daxpedda |
5 participants
This pull request adds support for the
AbstractRangeandStaticRangeinterfaces to wasm-bindgen, enabling Rust developers to interact with these DOM range objects for improved web API compatibility.