wasm3: fix incorrect download URL #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`PKG_SOURCE_URL` must not point to the `.tar.gz` file, instead it must point to the directory of the download, while `PKG_SOURCE` points to the `.tar.gz` See the [**Creating packages** guide on the OpenWRT Wiki][1]. As an example, see the [websocketpp Makefile][2]. [1]: https://openwrt.org/docs/guide-developer/packages#buildpackage_variables [2]: https://github.com/openwrt/packages/blob/f08eb8552c6bd71124a5407fb37abe6dc4982ac3/libs/websocketpp/Makefile#L11-L13 on-behalf-of: @nqminds <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PKG_SOURCE_URLmust not point to the.tar.gzfile, instead it must point to the directory of the download, whilePKG_SOURCEpoints to the.tar.gzSee the Creating packages guide on the OpenWRT Wiki.
As an example, see the websocketpp Makefile.
For
PKG_VERSION:=0.5.0, release, the URL will be https://github.com/wasm3/wasm3/archive/v0.5.0/wasm3-0.5.0.tar.gz