Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2025 01 25 Project cleanup #418

Merged
merged 13 commits into from
Feb 1, 2025
Merged

2025 01 25 Project cleanup #418

merged 13 commits into from
Feb 1, 2025

Conversation

baalimago
Copy link
Collaborator

@baalimago baalimago commented Jan 28, 2025

I've added three code-checkers and one vulnerability check to ensure that the code quality is high:

  • Staticcheck is practically the successor to go lint, used to spot easy mistakes and homogenize the code to standardized idioms
  • gofumpt is like go fmt but stricter. If any diff is detected when it's running, pipeline will fail. This ensures there are no formatting changes in the codebase
  • go vet is a bit like staticcheck and ensures that there's no dangerous 'low hanging fruit'-errors
  • go vuln tool which looks through the packages of the project and reports any vulnerabilities

These tools yielded a lot of errors, and some are still there even after this PR is merged.
My idea is to work on these bit by bit, not solve all in this PR since this neighboring PR fixes some, for example.

TL;DR changes:

  • Added gofumpt, staticcheck, go vet and govulncheck into pipeline
  • Formatted all files
  • go mod tidy on all gomods
  • Fumpted the go
  • Cleaned up the existing pipeline so that it runs

@baalimago baalimago force-pushed the 2025-01-25_project-cleanup branch 2 times, most recently from 26b7775 to a8257a0 Compare January 28, 2025 17:51
@baalimago baalimago force-pushed the 2025-01-25_project-cleanup branch from a8257a0 to 8ae6ec8 Compare January 28, 2025 17:54
@baalimago baalimago requested a review from syrusakbary January 29, 2025 04:27
@baalimago baalimago merged commit 50a7979 into master Feb 1, 2025
1 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant