Fix WasiProcess::terminate() #4397
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously there was a redundant nested Arc and some general shennanigans for how the state was shared and accessed. This commit wraps the whole state in an Arc<> and removes the old nested arc or the inner state. It also makes a lot of fields private and exposes them through getters. NOTE: the WasiProcessInner should also be made private
The Wasi prefix is redundant.
Previously the code would mix up the output status of a thread/process with an instruction to exit with a specific code. The Process::terminate() method would just set the output status, leaving no way to check if a thread had actually terminated. This commit adds an additonal atomic flag that records if the process should exit, and changes the relevant code (signal processing etc) to check that flag. The terminate method now just sets this code and then sends a kill signal.
|
Got some changes in the integration tests. Need to investigate. |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix(wasix): Fix WasiProcess::terminate()
Previously the code would mix up the output status of a thread/process with
an instruction to exit with a specific code.
The Process::terminate() method would just set the output status,
leaving no way to check if a thread had actually terminated.
This commit adds an additonal atomic flag that records if the process
should exit, and changes the relevant code (signal processing etc) to
check that flag.
The terminate method now just sets this code and then sends a kill
signal.
NOTE: The PR also contains some cleanup of the WasiProcess internal state.
Best to review commit by commit.
Closes #4396