-
Notifications
You must be signed in to change notification settings - Fork 923
CI: add Cache step for more runs #5984
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds S3-based caching steps to several CI workflow jobs and removes the legacy Azure-based sccache configuration from multiple workflow files. The goal is to speed up CI runs by caching Rust build artifacts and dependencies.
- Added four new cache steps using
whywaita/actions-cache-s3@v2for jobs: test_nodejs, test_wasi_fyi, test_wasix, and test_build_jsc - Removed SCCACHE_AZURE_BLOB_CONTAINER and SCCACHE_AZURE_CONNECTION_STRING environment variables from test.yaml, build.yml, and benchmark.yaml
- Minor whitespace cleanup (removed empty lines) in test.yaml
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 8 comments.
| File | Description |
|---|---|
| .github/workflows/test.yaml | Added S3 cache steps to four jobs (test_nodejs, test_wasi_fyi, test_wasix, test_build_jsc) and removed sccache Azure env vars from three matrix jobs |
| .github/workflows/build.yml | Removed sccache Azure env vars and commented-out use_sccache parameter |
| .github/workflows/benchmark.yaml | Removed sccache Azure env vars |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Plus, I removed setting the
CARGO_ROOT_DIR, we should be fine caching only the default 2 locations, the same what rust-cache does: https://github.com/Swatinem/rust-cache?tab=readme-ov-file#cache-details.