-
Notifications
You must be signed in to change notification settings - Fork 923
deps: bump wasm-smith and enable fuzzers #5994
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR bumps the wasm-smith dependency from version 0.4.4 to 0.243.0 and updates the fuzzer targets to work with the new API. The changes improve error messages by including type information and modernize the fuzzer configuration to use the newer wasm-smith Config API directly instead of the deprecated ConfiguredModule wrapper.
Key changes:
- Updates wasm-smith from 0.4.4 to 0.243.0, transitioning from the old Config trait to the new wasm_smith::Config struct API
- Enhances error messages in compiler backends to include type information for easier debugging
- Refactors fuzzer targets to use custom wrapper structs and updated wasm-smith configuration patterns
Reviewed changes
Copilot reviewed 9 out of 10 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| Cargo.toml | Bumps wasm-smith version from 0.4.4 to 0.243.0 |
| Cargo.lock | Updates transitive dependencies for wasm-smith and removes old indexmap versions |
| lib/compiler-singlepass/src/codegen.rs | Adds type information to the "unimplemented type" error message |
| lib/compiler-cranelift/src/func_environ.rs | Includes type debug information in the ref.null unsupported feature error |
| fuzz/fuzz_targets/universal_singlepass.rs | Refactors to use custom SinglePassFuzzModule wrapper with new wasm-smith Config API and adds save_wasm_file helper |
| fuzz/fuzz_targets/universal_llvm.rs | Refactors to use custom LLVMPassFuzzModule wrapper with new wasm-smith Config API and adds save_wasm_file helper |
| fuzz/fuzz_targets/universal_cranelift.rs | Refactors to use custom CraneliftPassFuzzModule wrapper with new wasm-smith Config API and adds save_wasm_file helper |
| fuzz/fuzz_targets/metering.rs | Simplifies to use wasm_smith::Module directly instead of custom wrapper |
| fuzz/fuzz_targets/equivalence_universal.rs | Removes custom wrapper and uses wasm_smith::Module directly, updates API calls for store/instance patterns |
| fuzz/fuzz_targets/deterministic.rs | Removes custom wrapper and uses wasm_smith::Module directly |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Fixes: #5931