CI: run some tests for all compilers #6030
Open
+17
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors test functions in the compilers test suite to use the #[compiler_test] macro instead of the standard #[test] attribute. This enables these tests to run across all available compilers (LLVM, Cranelift, Singlepass) and allows for better filtering when certain compiler features are not enabled on specific architectures (e.g., Cranelift on LoongArch64).
Key changes:
- Tests now receive a
Configparameter that provides compiler-specific configuration - Store instances are created via
config.store()instead of using default initialization - Functions return
Result<()>to align with the compiler test framework conventions
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tests/compilers/deterministic.rs | Converted two deterministic compilation tests to use the compiler_test framework, updating signatures and store creation |
| tests/compilers/artifact.rs | Converted artifact serialization roundtrip test to use the compiler_test framework, adding Result return type |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That's going to help filtering out the tests if a feature is not enabled (e.g. for
craneliftonLoongArch64).