fix(wasix): report /dev/null as a character device#6465
Open
artemyarulin wants to merge 1 commit intomainfrom
Open
fix(wasix): report /dev/null as a character device#6465artemyarulin wants to merge 1 commit intomainfrom
artemyarulin wants to merge 1 commit intomainfrom
Conversation
16b6270 to
39dd717
Compare
Arshia001
requested changes
Apr 20, 2026
| file: Mutex::new(file), | ||
| metadata: { | ||
| let time = time(); | ||
| let is_char_device = path.starts_with("/dev"); |
Member
There was a problem hiding this comment.
This check is way too broad. Off the top of my head, nothing prevents wasix apps from creating normal files in /dev, and this also creates real chances for regressions if we add more things to /dev from the host side.
Contributor
Author
Shield - Regression 💩💩💩
Example crash from Python
Example crash from Node.js
Example crash from PHP
Example crash from Rust
More changed tests
Install shield
Artifacts
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix WASIX
/dev/nullmetadata so it stats as a character device instead of a regular file.Previously,
/dev/nullbehaved like a null device for I/O, butstat()/fstat()reported it as a regular file.