Prompt interface and bug fixes #14
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch abstracts away the fiber runtime initialisation and finalisation procedures.
This patch is a stab at defining a prompt-oriented interface. I have implemented a somewhat working version of it in Asyncify, though, there are some caveats around forwarding. I think we need a trampoline to make forwarding more robust.
ishmis
reviewed
Mar 11, 2025
| $(ASYNCIFY) hello_prompt_asyncfiy.pre.wasm -o hello_prompt_asyncify.wasm | ||
| chmod +x hello_prompt_asyncify.wasm | ||
|
|
||
| hello_forward_prompt_asyncify.wasm: inc/fiber.h src/asyncify/asyncify_prompt_impl.c examples/prompt/hello_forward.c |
There was a problem hiding this comment.
i think the examples/prompt folder wasn't committed
There was a problem hiding this comment.
Thanks. The latest commit adds them.
ishmis
reviewed
Mar 11, 2025
| // * ACTIVE: the fiber is actively executing. | ||
| // * YIELDING: the fiber is suspended. | ||
| // * DONE: the fiber is finished (i.e. run to completion). | ||
| typedef enum { ACTIVE, YIELDING, DONE, FORWARDING, YIELD_FORWARDING } fiber_state_t; |
There was a problem hiding this comment.
i think YIELD_FORWARDING might not be used anywhere
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch is a stab at defining a prompt-oriented interface. I have
implemented a somewhat working version of it in Asyncify, though,
there are some caveats around forwarding. I think we need a trampoline
to make forwarding more robust.