Skip to content

Remove conditional return instructions #1486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Apr 27, 2025
Merged

Conversation

Robbepop
Copy link
Member

@Robbepop Robbepop commented Apr 26, 2025

Closes #1482.

ToDos

  • Some translation tests that have been commented out need to be updated instead.
  • One Wast test is still failing and I have not yet figured out why.
  • Check how Wasmi execution performance is affected by this change.
    • Benchmarks show minimal improvements across the board. Though some of those improvements are within the range of noise.

Copy link

codecov bot commented Apr 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.33%. Comparing base (8e8495b) to head (b8a39d3).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1486      +/-   ##
==========================================
+ Coverage   71.27%   71.33%   +0.06%     
==========================================
  Files         172      172              
  Lines       16504    16407      -97     
==========================================
- Hits        11763    11704      -59     
+ Misses       4741     4703      -38     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Robbepop Robbepop marked this pull request as ready for review April 26, 2025 09:49
@Robbepop Robbepop changed the title WIP: remove conditional return instructions Remove conditional return instructions Apr 26, 2025
@Robbepop Robbepop merged commit 688a545 into main Apr 27, 2025
19 checks passed
@Robbepop Robbepop deleted the rf-remove-conditional-returns branch April 27, 2025 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

wasmi_ir: remove conditional return instructions
1 participant