Skip to content

Make Instruction::update_branch_offset usable by both FuncTranlator backends - #1560

Merged
Robbepop merged 3 commits into
mainfrom
rf-update-branch-offsets-generically
Jul 10, 2025
Merged

Make Instruction::update_branch_offset usable by both FuncTranlator backends#1560
Robbepop merged 3 commits into
mainfrom
rf-update-branch-offsets-generically

Conversation

@Robbepop

@Robbepop Robbepop commented Jul 10, 2025

Copy link
Copy Markdown
Member

This allows to avoid code duplication and simplifies integration of #1512.

@Robbepop Robbepop changed the title Make Instruction::update_branch_offset generically useful between FuncTranlator backends Make Instruction::update_branch_offset usable by both FuncTranlator backends Jul 10, 2025
@codecov

codecov Bot commented Jul 10, 2025

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 83.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 72.23%. Comparing base (ae9496b) to head (5c19cff).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
crates/wasmi/src/engine/translator/comparator.rs 83.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1560      +/-   ##
==========================================
- Coverage   72.25%   72.23%   -0.03%     
==========================================
  Files         179      179              
  Lines       16333    16331       -2     
==========================================
- Hits        11801    11796       -5     
- Misses       4532     4535       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Robbepop
Robbepop merged commit d73abed into main Jul 10, 2025
18 of 19 checks passed
@Robbepop
Robbepop deleted the rf-update-branch-offsets-generically branch July 10, 2025 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant