Add missing domain check to isForumRoute and isCpRoute
#87
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the `Waterhole::isForumRoute()` and `Waterhole::isCpRoute()` methods only check that the request path matches. This creates issues when a custom domain is specified in `config/system.php`, especially when integrated into an existing Laravel project. This commit adds a check to ensure the domain matches if one is specified in the `system` config.
Contributor
Author
|
Note: I could not find any testing setup in the repository, so I tested the various configuration permutations in my own application. If you would like me to add tests to this pull request, just let me know where I should put them, and I'll be happy to do so! |
Laravel can be configured to use immutable Carbon dates with `Date::use(CarbonImmutable::class)`. `DateTimeInterface` is the common interface for `DateTime` and `DateTimeImmutable`. This commit updates `DateTime`-typed parameters to `DateTimeInterface` to support immutable dates.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the
Waterhole::isForumRoute()andWaterhole::isCpRoute()methods only check that the request path matches.This creates issues when a custom domain is specified in
config/system.php, especially when integrated into an existing Laravel project.This commit adds a check to ensure the domain matches if one is specified in the
systemconfig.Resolves #86