Refactor parse_logger to handle structured logger records with error …#33
Merged
JasonBrave merged 5 commits intomainfrom Jul 27, 2025
Merged
Refactor parse_logger to handle structured logger records with error …#33JasonBrave merged 5 commits intomainfrom
JasonBrave merged 5 commits intomainfrom
Conversation
JasonBrave
requested changes
May 26, 2025
a5c4195 to
f71a414
Compare
77fe8d8 to
c408273
Compare
c408273 to
e04ddec
Compare
e04ddec to
04b290f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request includes a significant rewrite of the
parse_loggerfunction inparsley/parsley.pyto improve its robustness, readability, and adherence to the expected logger record format. The new implementation introduces structured parsing with validation and error handling.Changes to
parse_loggerfunction:Improved Input Handling:
strtobytesto align with the binary format of logger records.Logger Record Parsing:
structmodule for parsing the header (SID,timestamp, andDLC) in a structured and endian-aware manner.Validation and Error Handling:
SIDconstraints,DLCrange, and payload length. RaisesValueErrorfor any structural issues.Logging for Debugging:
printstatement to log parsed values (page_number,SID,timestamp,DLC, anddata) for debugging purposes.…handlingThis change is