Updated test_utils.py to include the new sid format#41
Conversation
ChrisYx511
left a comment
There was a problem hiding this comment.
For stacking instructions, see https://abhinav.github.io/git-spice/start/
ChrisYx511
left a comment
There was a problem hiding this comment.
Also please tag the issue with the PR all the time.
|
Got rid of the commented code |
|
For this issue |
|
@ShreyShingala please include the "For this issue" by editing your original PR description, not in a comment. Also, it would be great if you didn't mask the link. 😃 Edit: I've added it! |
There was a problem hiding this comment.
Rename the file from test_utils to just utils.py, it is confusing as this is a utility and not a test.
Also, because this is a utility, the utility should also have accompanying unit tests in a utils_test.py file.
Please rename and add accompanying unit tests before requesting a re-review.
86b8d3b to
d7825c5
Compare
For waterloo-rocketry/2025-software-issues#63
Edited the test_utils.py so that it uses the new SID format as opposed to the previous two variable SID format. Left the old format in comments as it is still used in some test cases, which needs to be fixed.
Also renamed the original file test_utils.py to utils.py, and created accompanying tests in the file utils_test.py
This change is