Conversation
Contributor
Author
|
This change is part of the following stack: Change managed by git-spice. |
e1a9fac to
1d6db70
Compare
1d6db70 to
dd315f6
Compare
vincentjguo
previously approved these changes
Oct 6, 2025
vincentjguo
left a comment
There was a problem hiding this comment.
Not sure about all those alerts but I think the files you edited are fine
zangjiucheng
previously approved these changes
Oct 7, 2025
Member
zangjiucheng
left a comment
There was a problem hiding this comment.
LGTM, there is known warning about pytest we didn't fix that last year. (Could be fixed later)
b93dad2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For waterloo-rocketry/2025-software-issues#69
uv.lockand detailedpyproject.tomlto replacesetup.pyuv_buildas the module builder.Note:
requirements.txthas been kept to maintain compatibility withpipand related utilities.Build:
uv syncto pull packagesuv buildto buildThis change is