Workflow update

[JasonBrave]

No description provided.

[taisirhassan]

look at the comments please and change

[taisirhassan]

can we replace atoi with std::stoi for proper error handling.

atoi returns 0 for invalid input with no error indication. If a user provides an invalid seed value (e.g., "abc"), it silently becomes 0, which could lead to confusion during debugging.

				try {
					seed = std::stoi(optarg);
				} catch (const std::exception &e) {
					std::cerr << "Invalid seed value: " << optarg << std::endl;
					return EXIT_FAILURE;
				}

[taisirhassan]

can we add validation for nullptr and duplicate test names?

rn the constructor has two potential issues:

if test_name is nullptr, storing it in the map will cause undefined behaviour.

also duplicate test names silently overwrite the previous test, which could mask bugs.
can we consider adding validation:

smth like

 rockettest_test::rockettest_test(const char *test_name) : name(test_name) {
	if (test_name == nullptr) {
		std::cerr << "Error: test_name cannot be null" << std::endl;
		std::abort();
	}
	if (tests.contains(test_name)) {
		std::cerr << "Error: duplicate test name '" << test_name << "'" << std::endl;
		std::abort();
	}
     tests[test_name] = this;
 }

[taisirhassan]

can we add a virtual destructor to the polymorphic base class.

[taisirhassan]

Suggested change

	virtual ~rockettest_test() = default;

[taisirhassan]

can we wrap the macro in do-while(0) and document the test_passed requirement that users must declare a bool test_passed variable in the scope where this macro is invoked?

[taisirhassan]

rn the current command has several issues this also applies to local script as well:

• one Glob patterns (include/.h, common/.c) may not expand correctly in this context

• No compilation database is provided, which clang-tidy needs for accurate cross-file analysis

• Missing error handling (the step should fail if clang-tidy finds issues, which --warnings-as-errors handles, but shell errors are not caught)

I would change to use a shell env script something like this is more reliable and better for clang-tidy

       - name: Run lint check
         id: run-lint
         shell: bash
        run: |
          set -e
          find include -name "*.h" -o -name "*.c" > files.txt
          find common -name "*.c" >> files.txt
          if [ -s files.txt ]; then
            xargs -a files.txt clang-tidy-21 \
              --warnings-as-errors="*" \
              --checks="clang-*,misc-*" \
              -- -std=c99 -pedantic -Iinclude
          else
            echo "No files found to lint"
            exit 1
          fi

[JasonBrave]

The rockettest is copied from canlib, will take a look at the comments in a future PR