Conversation
x-ximena
force-pushed
the
issue-58-littlefs-config
branch
from
be67e77 to
84694e6
Compare
JasonBrave
requested changes
Nov 25, 2025
Member
JasonBrave
left a comment
JasonBrave
left a comment
There was a problem hiding this comment.
please rename stm32 folder to stm32h7
Member
|
Also please append ' stm32h7/.c' to line 20 of this file https://github.com/waterloo-rocketry/rocketlib/blob/main/.github/workflows/clang-format-check.yml |
JasonBrave
requested changes
Nov 28, 2025
JasonBrave
reviewed
Nov 28, 2025
Member
JasonBrave
left a comment
JasonBrave
left a comment
There was a problem hiding this comment.
Overall LGTM pending testing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #58