Skip to content

Conversation

@kurbansitterley
Copy link
Contributor

Fixes/Resolves:

Adds the Air-Water Equilibrium (AWE) property model, tests, and docs to WaterTAP.

Summary/Motivation:

This is a property model developed for REFLO that is meant to describe a liquid-air system that could be used for prommis. Other models that use this property model will follow after this is merged

Changes proposed in this PR:

  • Add AWE property model
  • Add test for AWE property model
  • Add AWE docs

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the license terms described in the LICENSE.txt file at the top level of this directory.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@adam-a-a adam-a-a requested a review from dallan-keylogic July 23, 2025 04:27
@ksbeattie ksbeattie added the Priority:Normal Normal Priority Issue or PR label Jul 24, 2025
@kurbansitterley
Copy link
Contributor Author

kurbansitterley commented Jul 31, 2025

rule_pressure_vap_sat is defined multiple times, causing the pylint failure. I am not sure how to get pylint to ignore this.

/ (water_temp_degC_dimensionless + self.params.huang_coeff_D1)
)

def rule_pressure_vap_sat(b, h2o):
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lbianchi-lbl here is the function that is redefined

else:
add_object_reference(self, "henry_comp", self.params.henry_comp)

# pylint: disable=function-redefinition
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lbianchi-lbl and here is my attempt at coercing pylint

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kurbansitterley, to disable a pylint check, I believe it needs to be on the exact line that is failing the check, so it would need to be on the line (as a comment at the end) where the function is declared. In this case lines: 2249 & 2261.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ksbeattie ok putting it on each line and then running black caused it to not be on the same line anymore, so I put it at the top of the file, let's see if that works

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heh, didn't work. I think just putting the one disable at the beginning of the _pressure_vap_sat function (~line 2178) might be the best approach here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request Priority:Normal Normal Priority Issue or PR PrOMMiS property_model

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants