-
Notifications
You must be signed in to change notification settings - Fork 84
Add Air-Water Equilibrium Property Package #1607
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add Air-Water Equilibrium Property Package #1607
Conversation
|
|
| / (water_temp_degC_dimensionless + self.params.huang_coeff_D1) | ||
| ) | ||
|
|
||
| def rule_pressure_vap_sat(b, h2o): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lbianchi-lbl here is the function that is redefined
| else: | ||
| add_object_reference(self, "henry_comp", self.params.henry_comp) | ||
|
|
||
| # pylint: disable=function-redefinition |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lbianchi-lbl and here is my attempt at coercing pylint
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kurbansitterley, to disable a pylint check, I believe it needs to be on the exact line that is failing the check, so it would need to be on the line (as a comment at the end) where the function is declared. In this case lines: 2249 & 2261.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ksbeattie ok putting it on each line and then running black caused it to not be on the same line anymore, so I put it at the top of the file, let's see if that works
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Heh, didn't work. I think just putting the one disable at the beginning of the _pressure_vap_sat function (~line 2178) might be the best approach here.
…blackify some code in doc code
…to air_water_eq_prop_pack
Fixes/Resolves:
Adds the Air-Water Equilibrium (AWE) property model, tests, and docs to WaterTAP.
Summary/Motivation:
This is a property model developed for REFLO that is meant to describe a liquid-air system that could be used for prommis. Other models that use this property model will follow after this is merged
Changes proposed in this PR:
Legal Acknowledgement
By contributing to this software project, I agree to the following terms and conditions for my contribution: