Skip to content

ASM3 Refinement #1618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
luohezhiming wants to merge 130 commits into
base: main
Choose a base branch
from
Open

ASM3 Refinement #1618

luohezhiming wants to merge 130 commits into from

Conversation

@luohezhiming
Copy link
Contributor

@luohezhiming luohezhiming commented Aug 5, 2025

Fixes/Resolves:

replace this with the issue #1613 #1615 #1616 fixed or resolved, if no issue exists then a brief statement of what this PR does

Summary/Motivation:

Changes proposed in this PR:

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the license terms described in the LICENSE.txt file at the top level of this directory.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@luohezhiming
add
7d35890
@luohezhiming
Merge branch 'main' of https://github.com/watertap-org/watertap
4766c52
@luohezhiming
Merge branch 'main' of https://github.com/watertap-org/watertap
ef81bae
@luohezhiming
Merge branch 'main' of https://github.com/watertap-org/watertap
168bbaf
@luohezhiming
Merge branch 'main' of https://github.com/watertap-org/watertap
a09b4e9
@luohezhiming
Merge branch 'main' of https://github.com/watertap-org/watertap
44a22e8
@luohezhiming
Merge branch 'main' of https://github.com/watertap-org/watertap
1c1a135
@luohezhiming
Merge branch 'main' of https://github.com/watertap-org/watertap
401f997
@luohezhiming
delete redundant files
258f6fe
@luohezhiming
Merge branch 'main' of https://github.com/watertap-org/watertap
2c994c3
@luohezhiming
Merge branch 'main' of https://github.com/watertap-org/watertap
5b6baed
@luohezhiming
Merge branch 'main' of https://github.com/watertap-org/watertap
0afa551
@luohezhiming
Merge branch 'main' of https://github.com/watertap-org/watertap
479fb6d
@luohezhiming
Merge branch 'main' of https://github.com/watertap-org/watertap
b393ed0
@luohezhiming
Merge branch 'main' of https://github.com/watertap-org/watertap
708ad0a
@luohezhiming
Merge branch 'main' of https://github.com/watertap-org/watertap
5a69761
@luohezhiming
Merge branch 'main' of https://github.com/watertap-org/watertap
112415a
@luohezhiming
Merge branch 'main' of https://github.com/watertap-org/watertap
93737c0
@luohezhiming
Merge branch 'main' of https://github.com/watertap-org/watertap
3162e34
@luohezhiming
Merge branch 'main' of https://github.com/watertap-org/watertap
637b32d
@luohezhiming
Merge branch 'main' of https://github.com/watertap-org/watertap
ea4e066
@luohezhiming
Merge branch 'main' of https://github.com/watertap-org/watertap
84a2900
@luohezhiming
Merge branch 'main' of https://github.com/watertap-org/watertap
17bc5e3
@luohezhiming
Merge branch 'main' of https://github.com/watertap-org/watertap
f816483
@luohezhiming
Merge branch 'main' of https://github.com/watertap-org/watertap
fea68e3
@luohezhiming
Merge branch 'main' of https://github.com/watertap-org/watertap
c19fba5
@luohezhiming
Merge branch 'main' of https://github.com/watertap-org/watertap
0754d21
@luohezhiming
Merge branch 'main' of https://github.com/watertap-org/watertap
9dcece1
@luohezhiming
Merge branch 'main' of https://github.com/watertap-org/watertap
a5325c9
@luohezhiming
Merge branch 'main' of https://github.com/watertap-org/watertap
c4bc3ef
luohezhiming added 22 commits July 1, 2024 14:35
@luohezhiming
Merge branch 'main' of https://github.com/watertap-org/watertap
5385f9f
@luohezhiming
Merge branch 'main' of https://github.com/watertap-org/watertap
9bd6313
@luohezhiming
Merge branch 'main' of https://github.com/watertap-org/watertap
9ff6789
@luohezhiming
Merge branch 'main' of https://github.com/watertap-org/watertap
3c29568
@luohezhiming
Merge branch 'main' of https://github.com/watertap-org/watertap
2e16921
@luohezhiming
Merge branch 'main' of https://github.com/watertap-org/watertap
c515d2d
@luohezhiming
Merge branch 'main' of https://github.com/watertap-org/watertap
da9d7ed
@luohezhiming
Merge branch 'main' of https://github.com/watertap-org/watertap
0ac5716
@luohezhiming
Merge branch 'main' of https://github.com/watertap-org/watertap
03424f1
@luohezhiming
Merge branch 'main' of https://github.com/watertap-org/watertap
7a52494
@luohezhiming
Merge branch 'main' of https://github.com/watertap-org/watertap
12ed69d
@luohezhiming
Merge branch 'main' of https://github.com/watertap-org/watertap
6d5aa53
@luohezhiming
Merge branch 'main' of https://github.com/watertap-org/watertap
2b431d1
@luohezhiming
Merge branch 'main' of https://github.com/watertap-org/watertap
3b184c3
@luohezhiming
Merge branch 'main' of https://github.com/watertap-org/watertap
17b72e4
@luohezhiming
Merge branch 'main' of https://github.com/watertap-org/watertap
64bb52d
@luohezhiming
Merge branch 'main' of https://github.com/watertap-org/watertap
585e38f
@luohezhiming
Merge branch 'main' of https://github.com/watertap-org/watertap
ebd1400
@luohezhiming
Merge branch 'main' of https://github.com/watertap-org/watertap
d4a0a95
@luohezhiming
Merge branch 'main' of https://github.com/watertap-org/watertap
72cc091
@luohezhiming
Merge branch 'main' of https://github.com/watertap-org/watertap
fc74573
@luohezhiming
refine ASM3 model
1062318
@luohezhiming luohezhiming self-assigned this Aug 5, 2025
MarcusHolly
MarcusHolly approved these changes Aug 6, 2025
View reviewed changes
Copy link
Contributor

@MarcusHolly MarcusHolly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ksbeattie ksbeattie added the Priority:High High Priority Issue or PR label Aug 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MarcusHolly MarcusHolly MarcusHolly approved these changes

@adam-a-a adam-a-a Awaiting requested review from adam-a-a adam-a-a is a code owner

@agarciadiego agarciadiego Awaiting requested review from agarciadiego agarciadiego is a code owner

@Morgan88888888 Morgan88888888 Awaiting requested review from Morgan88888888

At least 2 approving reviews are required to merge this pull request.

Assignees

@luohezhiming luohezhiming

Labels

Priority:High High Priority Issue or PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@luohezhiming @MarcusHolly @ksbeattie @kurbansitterley