Skip to content

Conversation

@sufikaur
Copy link
Contributor

@sufikaur sufikaur commented Oct 8, 2025

Fixes/Resolves:

Issue #1657

Summary/Motivation:

Add support for newer python versions

Changes proposed in this PR:

  • adds pytest to workflow for versions 3.12 and 3.13

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the license terms described in the LICENSE.txt file at the top level of this directory.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@sufikaur sufikaur self-assigned this Oct 8, 2025
@ksbeattie ksbeattie added the Priority:High High Priority Issue or PR label Oct 9, 2025
@MarcusHolly
Copy link
Contributor

Need to evaluate why the BSM2 UI tests are failing while the BSM2 flowsheet tests don't have any issues.

@MarcusHolly
Copy link
Contributor

MarcusHolly commented Nov 4, 2025

Summary of the changes I made:

  1. Undid the GUI changes from BSM2 GUI Fix #1634
  2. Added Windows 3.11 pytest marks for the failing tests

We can revisit if these solutions will suffice in the next dev call

@sufikaur
Copy link
Contributor Author

sufikaur commented Nov 6, 2025

I will take a stab at integrating regex so we don't need to use the python version marks for failing tests (2)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Priority:High High Priority Issue or PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants