Create a tutorial for Parmest new API #1672
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luohezhiming
requested review from
MarcusHolly,
adam-a-a,
avdudchenko and
kurbansitterley
as code owners
MarcusHolly
reviewed
Oct 24, 2025
Contributor
MarcusHolly
left a comment
MarcusHolly
left a comment
There was a problem hiding this comment.
Mainly minor comments
| "execution_count": null, | ||
| "execution_count": 1, |
Contributor
There was a problem hiding this comment.
Were any changes actually made to this file? It's hard to tell because a lot of lines have changed - mainly because this tutorial did not initially display outputs. So now all of the outputs are appearing as new lines. I'm indifferent as to whether tutorials should have the outputs pre-loaded or not, but in this case, clearing the outputs would make it easier to review. There may actually be no changes made to this notebook...
| "source": [ | ||
| "data_formatted = get_formatted_data(data) \n", | ||
| "print(data_formatted)\n", | ||
| "# print(data_formatted.to_markdown())" |
| }, | ||
| { | ||
| "cell_type": "code", | ||
| "execution_count": 12, |
Contributor
There was a problem hiding this comment.
I suggest re-running the cells all in order or clearing the output. Seems like all the cells were run, but then some were re-run and others were not
Co-authored-by: MarcusHolly <[email protected]>
Co-authored-by: MarcusHolly <[email protected]>
Co-authored-by: MarcusHolly <[email protected]>
Co-authored-by: MarcusHolly <[email protected]>
Co-authored-by: MarcusHolly <[email protected]>
…parmest_tutorial
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes/Resolves:
(replace this with the issue # fixed or resolved, if no issue exists then a brief statement of what this PR does)
Summary/Motivation:
Changes proposed in this PR:
Legal Acknowledgement
By contributing to this software project, I agree to the following terms and conditions for my contribution: