Skip to content

Conversation

@MarcusHolly
Copy link
Contributor

Summary/Motivation:

The LSRRO sweep test could not be run due to a circular import:

ImportError: cannot import name '_lsrro_presweep' from partially initialized module 'watertap.flowsheets.lsrro.multi_sweep' (most likely due to a circular import)

Changes proposed in this PR:

  • Imports _lsrro_presweep inside of the function rather than at the top of the lsrro flowsheet file

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the license terms described in the LICENSE.txt file at the top level of this directory.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

outputs = {}
nx = points_per_sweep
if m is None:
from watertap.flowsheets.lsrro.multi_sweep import _lsrro_presweep
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will not fix the issue completely--technically. Maybe I can pitch in since I think I caused this problem with the UCI workshop scramble.

@MarcusHolly
Copy link
Contributor Author

Will be addressed in #1700

@ksbeattie ksbeattie added the Priority:Normal Normal Priority Issue or PR label Nov 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Priority:Normal Normal Priority Issue or PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants