Skip to content

Add Clarity to RO w/ERD GUI Descriptions #1703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adam-a-a merged 4 commits into from
Dec 3, 2025
Merged

Add Clarity to RO w/ERD GUI Descriptions #1703

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
97506e8
Add more clarity to vol flow rate descriptions
MarcusHolly Dec 2, 2025
2df79c0
Update NaCl descriptions
MarcusHolly Dec 2, 2025
8274a7a
Minor change for consistency
MarcusHolly Dec 2, 2025
0587580
Apply suggestions from code review
adam-a-a Dec 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions watertap/flowsheets/RO_with_energy_recovery/RO_with_energy_recovery_ui.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -268,7 +268,7 @@ def export_variables(flowsheet=None, exports=None, build_options=None, **kwargs)
# Feed
exports.add(
obj=fs.feed.properties[0].flow_vol_phase["Liq"],
name="Volumetric flow rate",
name="Feed volumetric flow rate",
ui_units=pyunits.m**3 / pyunits.hour,
display_units="m3/hr",
rounding=2,
Expand All @@ -279,7 +279,7 @@ def export_variables(flowsheet=None, exports=None, build_options=None, **kwargs)
)
exports.add(
obj=fs.feed.properties[0].conc_mass_phase_comp["Liq", "NaCl"],
name="NaCl concentration",
name="Feed NaCl concentration",
ui_units=pyunits.g / pyunits.L,
display_units="g/L",
rounding=2,
Expand All @@ -292,7 +292,7 @@ def export_variables(flowsheet=None, exports=None, build_options=None, **kwargs)
# Product
exports.add(
obj=fs.product.properties[0].flow_vol,
name="Volumetric flow rate",
name="Product volumetric flow rate",
ui_units=pyunits.m**3 / pyunits.hr,
display_units="m3/h",
rounding=2,
Expand All @@ -303,7 +303,7 @@ def export_variables(flowsheet=None, exports=None, build_options=None, **kwargs)
)
exports.add(
obj=fs.product.properties[0].conc_mass_phase_comp["Liq", "NaCl"],
name="NaCl concentration",
name="Product NaCl concentration",
ui_units=pyunits.g / pyunits.L,
display_units="g/L",
rounding=3,
Expand All @@ -316,22 +316,22 @@ def export_variables(flowsheet=None, exports=None, build_options=None, **kwargs)
# Disposal
exports.add(
obj=fs.disposal.properties[0].flow_vol,
name="Volumetric flow rate",
name="Waste brine volumetric flow rate",
ui_units=pyunits.m**3 / pyunits.hr,
display_units="m3/h",
rounding=2,
description="Outlet product water volumetric flow rate",
description="Outlet brine volumetric flow rate",
is_input=False,
is_output=True,
output_category="Disposal",
)
exports.add(
obj=fs.disposal.properties[0].conc_mass_phase_comp["Liq", "NaCl"],
name="NaCl concentration",
name="Waste brine NaCl concentration",
ui_units=pyunits.g / pyunits.L,
display_units="g/L",
rounding=3,
description="Outlet product water NaCl concentration",
description="Outlet brine NaCl concentration",
is_input=False,
is_output=True,
output_category="Disposal",
Expand Down
Loading