Skip to content

Enhance GUI Output Descriptions #1710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sufikaur merged 4 commits into from
Dec 12, 2025
Merged

Enhance GUI Output Descriptions #1710

sufikaur merged 4 commits into from
Dec 12, 2025

Conversation

@MarcusHolly
Copy link
Contributor

@MarcusHolly MarcusHolly commented Dec 8, 2025

Summary/Motivation:

When you try to sweep variables on the GUI, it can be hard to decipher what is meant by "Volumetric flow rate", so this PR now specifies "Feed volumetric flow rate" in these scenarios.

Changes proposed in this PR:

  • Adds better descriptions for outputs in the GUI

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the license terms described in the LICENSE.txt file at the top level of this directory.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@MarcusHolly MarcusHolly self-assigned this Dec 8, 2025
kurbansitterley
kurbansitterley requested changes Dec 8, 2025
View reviewed changes
Copy link
Contributor

@kurbansitterley kurbansitterley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at some of the existing labels, some of these changes were badly needed.

I made two minor suggestions.

@ksbeattie ksbeattie added the Priority:High High Priority Issue or PR label Dec 11, 2025
@sufikaur sufikaur merged commit 9361b65 into watertap-org:main Dec 12, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kurbansitterley kurbansitterley kurbansitterley approved these changes

@adam-a-a adam-a-a Awaiting requested review from adam-a-a adam-a-a is a code owner

@luohezhiming luohezhiming Awaiting requested review from luohezhiming luohezhiming is a code owner

@avdudchenko avdudchenko Awaiting requested review from avdudchenko avdudchenko is a code owner

@carson-tucker carson-tucker Awaiting requested review from carson-tucker carson-tucker is a code owner

@ElmiraShamlou ElmiraShamlou Awaiting requested review from ElmiraShamlou ElmiraShamlou is a code owner

@bknueven bknueven Awaiting requested review from bknueven bknueven is a code owner

@agarciadiego agarciadiego Awaiting requested review from agarciadiego agarciadiego is a code owner

@Morgan88888888 Morgan88888888 Awaiting requested review from Morgan88888888

@lbibl lbibl Awaiting requested review from lbibl lbibl is a code owner

@johnson12742 johnson12742 Awaiting requested review from johnson12742 johnson12742 is a code owner

Assignees

@MarcusHolly MarcusHolly

Labels

Priority:High High Priority Issue or PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@MarcusHolly @kurbansitterley @ksbeattie @sufikaur