Skip to content

Add Reference to MVC Documentation #1715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ksbeattie merged 1 commit into from
Dec 18, 2025
Merged

Add Reference to MVC Documentation #1715

ksbeattie merged 1 commit into from
Dec 18, 2025

Conversation

@MarcusHolly
Copy link
Contributor

@MarcusHolly MarcusHolly commented Dec 17, 2025

Summary/Motivation:

The MVC flowsheet documentation did not have any references listed

Changes proposed in this PR:

  • Added reference to unit model doc
  • Added all references from unit model doc to flowsheet doc

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the license terms described in the LICENSE.txt file at the top level of this directory.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@MarcusHolly MarcusHolly self-assigned this Dec 17, 2025
@MarcusHolly MarcusHolly added the documentation Improvements or additions to documentation label Dec 17, 2025
@MarcusHolly
Copy link
Contributor Author

MarcusHolly commented Dec 17, 2025

@adam-a-a Can you double check that I added the correct reference here?

@ksbeattie ksbeattie added the Priority:High High Priority Issue or PR label Dec 18, 2025
@ksbeattie ksbeattie merged commit 723576a into watertap-org:main Dec 18, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adam-a-a adam-a-a adam-a-a approved these changes

@kurbansitterley kurbansitterley kurbansitterley approved these changes

@luohezhiming luohezhiming luohezhiming approved these changes

Assignees

@MarcusHolly MarcusHolly

Labels

documentation Improvements or additions to documentation Priority:High High Priority Issue or PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@MarcusHolly @adam-a-a @kurbansitterley @luohezhiming @ksbeattie