Skip to content

Conversation

@dallan-keylogic
Copy link
Contributor

Summary/Motivation:

As part of working on dynamics in WaterTap, I added material and energy density terms to the Seawater property package and made some improvements to unit model scaling.

Additionally, I found and fixed an issue when the MCAS property package was used 1) in a Feed block (and probably also Product block) when 2) using a time set with more than one element. The issue seems to have been caused because the state variables (either flow_mol_phase_comp or flow_mass_phase_comp depending on the configuration) were being created through the on-demand property framework, instead of creating them when initializing the state block. The fact that those state variables were not entirely initialized when the Feed block tried to create References to them at the unit-model level (moving the time index set from living on the state block to living on the state variable) caused an obscure Pyomo error.

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the license terms described in the LICENSE.txt file at the top level of this directory.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@ksbeattie ksbeattie added the Priority:Normal Normal Priority Issue or PR label Jan 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Priority:Normal Normal Priority Issue or PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants