Skip to content

Drop old Ruby and Rails support#35

Open
barthez wants to merge 1 commit into
watir:masterfrom
barthez:update-ruby-rails-deps
Open

Drop old Ruby and Rails support#35
barthez wants to merge 1 commit into
watir:masterfrom
barthez:update-ruby-rails-deps

Conversation

@barthez
Copy link
Copy Markdown
Contributor

@barthez barthez commented Feb 17, 2023

Require Ruby >= 3.0 and Rails >= 6.0

Ruby 2.7 is about to end its life: https://www.ruby-lang.org/en/downloads/branches/
Rails < 6 are no longer supported: https://guides.rubyonrails.org/maintenance_policy.html

Require Ruby >= 3.0 and Rails >= 6.0

Ruby 2.7 is about to end its life: https://www.ruby-lang.org/en/downloads/branches/
Rails < 6 are no longer supported: https://guides.rubyonrails.org/maintenance_policy.html
@barthez barthez marked this pull request as ready for review February 17, 2023 14:51
@jarmo
Copy link
Copy Markdown
Member

jarmo commented Feb 18, 2023

Thank you for this PR!

However, can you explain why these changes are necessary for this gem? What benefits do they bring in for current watir-rails users? As I see it - these changes might cause some headaches for the users instead of making anything better. They might not be able to upgrade this gem to get some bugfix if there will be any without the need to upgrade their entire ecosystem (either Rails or Ruby itself). It just seems too much of a hassle.

This gem also doesn't have a lot of code to suppor these legacy versions - if it was the opposite then I could see some benefit of simplifying this codebase.

Can you explain why did you start removing support for these older versions? Maybe you had some problems and I'm just missing the context.

@barthez
Copy link
Copy Markdown
Contributor Author

barthez commented Feb 20, 2023

Hey @jarmo,

I didn't look at it from maintainer perspective. You are right, as it might cause more troubles for some.

Where I see improvements is updating the test matrix with recent rails and ruby. Right now it tests against:

  • Rails 3, 4 and 7
  • Ruby 2.6 and 3.3

Full matrix with all supported version would be huge, so I would let you decide which versions it should be tested against.

If you have test run setup with latest version of both Rails and Ruby, maybe it is worth considering to setup CI to run on a schedule? Monthly? Semiannually?

@jarmo
Copy link
Copy Markdown
Member

jarmo commented Feb 20, 2023

Makes sense to update test matrix.

I'm not against removing old unsupported versions from there to keep it smaller/faster and if we accidentally break compatibility with these then I'd consider it force majeure, but I would not actively try to break compatibility as this PR currently does.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants