Drop old Ruby and Rails support#35
Conversation
Require Ruby >= 3.0 and Rails >= 6.0 Ruby 2.7 is about to end its life: https://www.ruby-lang.org/en/downloads/branches/ Rails < 6 are no longer supported: https://guides.rubyonrails.org/maintenance_policy.html
|
Thank you for this PR! However, can you explain why these changes are necessary for this gem? What benefits do they bring in for current This gem also doesn't have a lot of code to suppor these legacy versions - if it was the opposite then I could see some benefit of simplifying this codebase. Can you explain why did you start removing support for these older versions? Maybe you had some problems and I'm just missing the context. |
|
Hey @jarmo, I didn't look at it from maintainer perspective. You are right, as it might cause more troubles for some. Where I see improvements is updating the test matrix with recent rails and ruby. Right now it tests against:
Full matrix with all supported version would be huge, so I would let you decide which versions it should be tested against. If you have test run setup with latest version of both Rails and Ruby, maybe it is worth considering to setup CI to run on a schedule? Monthly? Semiannually? |
|
Makes sense to update test matrix. I'm not against removing old unsupported versions from there to keep it smaller/faster and if we accidentally break compatibility with these then I'd consider it force majeure, but I would not actively try to break compatibility as this PR currently does. |
Require Ruby >= 3.0 and Rails >= 6.0
Ruby 2.7 is about to end its life: https://www.ruby-lang.org/en/downloads/branches/
Rails < 6 are no longer supported: https://guides.rubyonrails.org/maintenance_policy.html