Skip to content

Conversation

@chameleon10712
Copy link

Fixed the following cases.
Case 1: When the path contains several underscore, ex. my_test/Carpetfuzz/output/relation/relation_tiffcp.json, the script cannot function normally.
Case 2: When the NLP model generate partial invalid relationship / arguments, the subprocess of executeCommand() may return the result to stderr instead of stdout. This leads rank_combination.py fail to generate the corresponding file.

@waugustus
Copy link
Owner

Hi, thank you for the fix. As for the second case, I don't quite understand why the subprocess of executeCommand() may return the result to stderr. Could you please provide a specific example?

@chameleon10712
Copy link
Author

Case like jpegtran from the latest libjpeg-turbo.
Without adding the stderr information, the rank_combination.py script will show [Error] Failed to get bitmap through cmd line

@waugustus
Copy link
Owner

Hello, thank you for your fix. Regarding the second issue, I tried running rank_combination.py on the latest version of libjpeg-turbo and didn't encounter this error. My version is commit 9b704f. Could you provide me with the version information you tested with? I believe your fix is sound; I'm just amazed at the existence of this issue.

root@f2c682b9b29f:~/programs/libjpeg-turbo# python3 ${CarpetFuzz}/scripts/rank_combination.py --combination ${CarpetFuzz}/output/combination/combination_jpegtran.txt --dict ${CarpetFuzz}/tests/dict/dict.json --bindir $PWD/build_carpetfuzz/bin --seeddir input
[OK] Successfully generate the ranked stub file - /root/CarpetFuzz/output/stubs/ranked_stubs_jpegtran.txt
root@f2c682b9b29f:~/programs/libjpeg-turbo# git log
commit 9b704f96b2dccc54363ad7a2fe8e378fc1a2893b (HEAD -> main, origin/main, origin/HEAD)
Author: DRC <information@libjpeg-turbo.org>
Date:   Tue Aug 15 11:03:57 2023 -0400
...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants