Feat: Implement Bitwise Operations and Unary Operators#250
Merged
LunaStev merged 1 commit intowavefnd:masterfrom Dec 17, 2025
Merged
Feat: Implement Bitwise Operations and Unary Operators#250LunaStev merged 1 commit intowavefnd:masterfrom
LunaStev merged 1 commit intowavefnd:masterfrom
Conversation
Add support for bitwise operations (shift, XOR, NOT) and unary operators (logical NOT, bitwise NOT) with proper operator precedence. Changes: - Update lexer to use C-style shift operators: - Change "rol" keyword to "<<" (shift left) - Change "ror" keyword to ">>" (shift right) - Maintain TokenType::Rol and TokenType::Ror internally - Add new operators to AST: - ShiftLeft (<<), ShiftRight (>>) - BitwiseXor (^), BitwiseNot (~) - LogicalNot (!) - Implement unary expression support: - Add Expression::Unary variant with operator and inner expression - Parse unary prefix operators (!, ~) in parse_expression - Generate LLVM IR for unary operations - Refactor expression parsing precedence hierarchy: - parse_logical_expression now calls parse_bitwise_expression - Add parse_bitwise_expression for |, ^ operators - Add parse_shift_expression for <<, >> operators - Maintain proper precedence: logical > bitwise > shift > relational - Implement LLVM code generation for new operators: - build_left_shift / build_right_shift for << and >> - build_not for bitwise NOT (~) - build_xor with const_int(1) for logical NOT (!) - Add comprehensive operator test (test70.wave): - Arithmetic operators (+, -, *, /, %) - Compound assignment (+=, -=, *=, /=) - Comparison operators (==, !=, <, <=, >, >=) - Logical operators (&&, ||, !) - Bitwise operators (|, ^, ~) - Shift operators (<<, >>) - Operator precedence and grouping Example usage: var x: i32 = 10; var y: i32 = x << 2; // 40 var z: i32 = ~x; // -11 (two's complement) var w: bool = !(x > 5); // false This completes Wave's operator set with industry-standard bitwise manipulation and unary operations, matching C/C++ operator syntax. Signed-off-by: LunaStev <luna@lunastev.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds support for bitwise operations (Shift, XOR, NOT) and unary operators (Logical NOT, Bitwise NOT). It also refactors the expression parsing logic to ensure proper operator precedence, completing a robust set of industry-standard operators for Wave.
Key Changes
1. Lexer & Syntax Update
rol/rorto standard<<(Shift Left) and>>(Shift Right) syntax.TokenType::RolandTokenType::Rorinternally for consistency.2. AST Enhancements
ExpressionandOperatorenums:<<,>>,^!(Logical NOT),~(Bitwise NOT)Expression::Unaryto represent prefix operations.3. Parser Refactoring (Precedence Hierarchy)
Logical>Bitwise(|,^) >Shift(<<,>>) >Relational(<,>, etc.).parse_bitwise_expressionandparse_shift_expressionmethods.4. LLVM Code Generation
build_left_shiftandbuild_right_shiftfor bitwise shifts.build_notfor bitwise NOT (~).build_xorwithconst_int(1)for logical NOT (!).5. Comprehensive Testing (
test70.wave)Example Usage