fix(bsp): add missing #include <string.h> in esp32_p4_wifi6_touch_lcd_7b.c#156
Open
Arganox wants to merge 1 commit into
Open
fix(bsp): add missing #include <string.h> in esp32_p4_wifi6_touch_lcd_7b.c#156Arganox wants to merge 1 commit into
Arganox wants to merge 1 commit into
Conversation
…_7b.c memcpy() is used (lines 518, 523) without including <string.h>. This compiles on older IDF versions due to transitive includes but fails on ESP-IDF v5.4.4 with -Werror=implicit-function-declaration.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
esp32_p4_wifi6_touch_lcd_7b.ccallsmemcpy()(lines 518 and 523) without including<string.h>.On older ESP-IDF versions this compiles because
string.his transitively pulled in by other headers. On ESP-IDF v5.4.4 (and likely any version with stricter implicit-declaration warnings), the build fails:Fix
Add
#include <string.h>alongside the existing includes.Testing
idf.py buildtargeting esp32p4 on ESP-IDF v5.4.4 after this change.