Replace time.After with a timer created only once for a function call. #1966
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexeykiselev
added
enhancement
Linter exclusion comments updated.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| // The peer was not found in the larges group, time to change the peer. | ||
| // Select the random peer from the group and return it along with a new score value. | ||
| i := rand.IntN(len(g.peers)) // #nosec: it's ok to use math/rand/v2 here | ||
| i := rand.IntN(len(g.peers)) //nolint: gosec // it's ok to use math/rand/v2 here. |
Check failure
Code scanning / gosec
Use of weak random number generator (math/rand or math/rand/v2 instead of crypto/rand) Error
| return PeerInfo{}, err | ||
| } | ||
| n := rand.IntN(len(ips)) // #nosec: it's ok to use math/rand/v2 here | ||
| n := rand.IntN(len(ips)) //nolint: gosec // it's ok to use math/rand/v2 here. |
Check failure
Code scanning / gosec
Use of weak random number generator (math/rand or math/rand/v2 instead of crypto/rand) Error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.